Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new landing page design #3870

Merged
merged 19 commits into from
Dec 10, 2024
Merged

docs: new landing page design #3870

merged 19 commits into from
Dec 10, 2024

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Nov 15, 2024

Todos

  • Fix button styling in landing page
  • fix font colors
  • make mobile responsive
  • update images where appropriate
  • fix images to scale and fit

Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2024
@thisisobate thisisobate marked this pull request as ready for review November 25, 2024 13:36
@thisisobate thisisobate requested review from a team as code owners November 25, 2024 13:36
@github-actions github-actions bot added the ops label Nov 25, 2024
docs/overrides/home.html Outdated Show resolved Hide resolved
@mowies
Copy link
Member

mowies commented Nov 26, 2024

@thisisobate on smaller mobile screens, the buttons on the hero section disappear. seems that they are pushed out of the blue section downward and are behind the grey section below

@nate-double-u
Copy link

Deploy preview: https://keptn--3870.org.readthedocs.build/3870/

@thisisobate thisisobate requested a review from odubajDT November 26, 2024 19:35
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the hero section CTA buttons still disappear on smaller mobile devices (chrome dev tools - iphone SE, same on physical iphone 6 that we tested)
  • the CNCF picture doesn't scale smaller on smaller screen. instead, it just overflows on the right
  • the 3 "what makes us special" pictures are neither vertically nor horizontally aligned
    • they don't start aligned with the text vertically
    • they are different width horizontally and are also not left or right aligned

Signed-off-by: thisisobate <[email protected]>
@thisisobate thisisobate requested a review from mowies December 2, 2024 14:11
@odubajDT
Copy link
Contributor

odubajDT commented Dec 10, 2024

  • the hero section CTA buttons still disappear on smaller mobile devices (chrome dev tools - iphone SE, same on physical iphone 6 that we tested)

    • the CNCF picture doesn't scale smaller on smaller screen. instead, it just overflows on the right

    • the 3 "what makes us special" pictures are neither vertically nor horizontally aligned

      • they don't start aligned with the text vertically
      • they are different width horizontally and are also not left or right aligned

Hi @thisisobate the problems in the hero section with the buttons still persist. The buttons are gone on mobile devices and the text is overflowing to the next section

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisobate
Copy link
Contributor Author

Can you show me a screenshot? I just tested on my mobile device iphone 15 and it works just fine

@mowies mowies changed the title docs: new landing page design (v3) docs: new landing page design Dec 10, 2024
@mowies
Copy link
Member

mowies commented Dec 10, 2024

All the rest was adjusted together in a meeting

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mowies mowies merged commit 4659fed into keptn:main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants